Skip to content

Conversation

@adr1anh
Copy link
Contributor

@adr1anh adr1anh commented Dec 24, 2025

Depends on 0xMiden/crypto#728

Describe your changes

Checklist before requesting a review

  • Repo forked and branch created from next according to naming convention.
  • Commit messages and codestyle follow conventions.
  • Commits are signed.
  • Relevant issues are linked in the PR description.
  • Tests added for new functionality.
  • Documentation/comments updated according to changes.
  • Updated `CHANGELOG.md'

@adr1anh adr1anh added the no changelog This PR does not require an entry in the `CHANGELOG.md` file label Dec 24, 2025
@huitseeker huitseeker force-pushed the al-migrate-p3-ver2 branch 13 times, most recently from 02468c7 to 116efcf Compare December 31, 2025 00:59
Base automatically changed from al-migrate-p3-ver2 to next January 2, 2026 19:42
@bobbinth
Copy link
Contributor

bobbinth commented Jan 4, 2026

@adr1anh - now that #2472 has been merged, could you refresh this PR?

adr1anh and others added 4 commits January 12, 2026 07:55
Renames only - no content changes.

The test input code changed from `0_u32.into()` to `Felt::new(0)`,
which changes the generated snapshot file names.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- miden-crypto → tracking-p3-0.4.2
- p3-miden-* → tracking-0.4.2
- upstream Plonky3 → main

API changes:
- Felt::from(u32) → Felt::from_u32()/Felt::new()
- as_int() → as_canonical_u64()
- Re-export traits from miden_crypto

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@huitseeker huitseeker marked this pull request as ready for review January 12, 2026 16:58
@huitseeker huitseeker marked this pull request as draft January 12, 2026 16:58
@adr1anh
Copy link
Contributor Author

adr1anh commented Jan 15, 2026

Superseded by #2547

@adr1anh adr1anh closed this Jan 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no changelog This PR does not require an entry in the `CHANGELOG.md` file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants